-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[widget Audit] toga.DetailedList #2025
Conversation
d9120c5
to
7fd0606
Compare
4b9ef7c
to
6f49004
Compare
… the need for a second ObjC object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor suggestions, but otherwise looking good (other than the single failing test)
async def add_row(event_widget, **kwargs): | ||
def add_row(event_widget, **kwargs): | ||
assert event_widget == widget | ||
assert kwargs == {} | ||
|
||
# Simulate a reload delay | ||
await probe.redraw("Wait for simulated reload") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made the test unreliable in --slow
mode, because the handler and the test function are running in separate asyncio tasks and there's no guarantee of which one will finish awaiting first.
Audit of DetailedList.
Builds on #2017 because of dependencies on Table and Sources (especially on GTK).
--coverage
flag when running the testbed; I was finding it cumbersome to have to run the entire test suite just to get coverage of a single widget.Fixes:
beeliza
anddetailedlist
examples do not show aDetailedList
on Android #1997ListSource
APIs #2071Audit checklist