-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide per-platform screenshots for each widget #2103
Conversation
33278ef
to
bbc16ee
Compare
54e5e31
to
afa4a3f
Compare
afa4a3f
to
e012896
Compare
This is currently failing RTD, plus Windows and Android testbed tests because the Windows and Android screenshots (and relative APIs) are missing. To get those, an implementation of In the process, I've noticed that tutorial4 isn't producing the right output on Windows; not sure where that regressed. |
e012896
to
d140e24
Compare
There are two separate problems:
|
d140e24
to
4f90d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WinForms Canvas will be fixed by #2184, and there's also a small change to the drawing instructions which will have to be copied from tutorial4.
I'm not sure what's happening on Android – maybe something to do with the Box not being big enough to hold the Canvas plus its padding?
The widget screenshots are currently all macOS widgets. This PR modifies the documentation to provide a tabview so that you can see what the widget will look like on each platform.
To ensure the screenshots remain consistent, a new demo app has been added that automatically generates all the screenshots. The only exceptions are WebView (web content isn't reliably included in screenshots on macOS, presumably for security reasons?), Window and MainWindow (which will require manual screenshots until #1930 lands, adding a full-screen capture API).
When this app runs, it generates a sample of each widget, takes a screenshot, crops the screenshot so that it only includes the widget, and saves the cropped screenshot in the app data folder.
Also adds:
Builds off #2160.
Fixes #2062.
PR Checklist: