Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS signing and notarization fixes #1100

Merged
merged 1 commit into from
Feb 14, 2023
Merged

macOS signing and notarization fixes #1100

merged 1 commit into from
Feb 14, 2023

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Feb 14, 2023

  • Stream Subprocess Command Output by Default #943 did not check whether the notarization commands require stream_output=False. It turns out that one of them does, because it reads your Apple username and password from stdin.
  • Made the code signing and briefcase package documentation pages link to each other. Also added a link in the error message when no code signing identities are available.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense, and some nice documentation/cross-linking improvements.

@freakboy3742 freakboy3742 merged commit 3119fd0 into beeware:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsmith @freakboy3742