Merge pull request #1100 from mhsmith/macos-signing

macOS signing and notarization fixes
beeware · Feb 14, 2023 · 3119fd0 · 3119fd0
2 parents 12525af + 6d88c36
commit 3119fd0
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 5 deletions.
diff --git a/changes/1100.bugfix.rst b/changes/1100.bugfix.rst
@@ -0,0 +1 @@
+The command to store notarization credentials no longer causes Briefcase to hang.
diff --git a/docs/how-to/code-signing/macOS.rst b/docs/how-to/code-signing/macOS.rst
@@ -182,5 +182,5 @@ certificate.
 Next steps
 ----------
 
-Now it's time to start using the Developer ID Application Certificate to sign,
-notarize, and distribute your application!
+Now you can use the certificate to sign and notarize your application with the
+:doc:`briefcase package </reference/commands/package>` command.
diff --git a/docs/reference/commands/package.rst b/docs/reference/commands/package.rst
@@ -62,4 +62,4 @@ Sign app with adhoc identity.
 ``-i <identity>`` / ``--identity <identity>``
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-The code signing identity to use when signing the app.
+The :doc:`code signing identity </how-to/code-signing/index>` to use when signing the app.
diff --git a/src/briefcase/platforms/macOS/__init__.py b/src/briefcase/platforms/macOS/__init__.py
@@ -243,7 +243,10 @@ def select_identity(self, identity=None):
                     ) from e
 
         if len(identities) == 0:
-            raise BriefcaseCommandError("No code signing identities are available.")
+            raise BriefcaseCommandError(
+                "No code signing identities are available: see "
+                "https://briefcase.readthedocs.io/en/stable/how-to/code-signing/macOS.html"
+            )
         elif len(identities) == 1:
             identity, identity_name = list(identities.items())[0]
         else:
@@ -497,6 +500,7 @@ def notarize(self, filename, team_id):
                                 profile,
                             ],
                             check=True,
+                            stream_output=False,  # Command reads from stdin.
                         )
                     except subprocess.CalledProcessError as e:
                         raise BriefcaseCommandError(

diff --git a/tests/platforms/macOS/app/test_package__notarize.py b/tests/platforms/macOS/app/test_package__notarize.py
@@ -176,6 +176,7 @@ def test_notarize_dmg_unknown_credentials(package_command, first_app_dmg):
                     "briefcase-macOS-DEADBEEF",
                 ],
                 check=True,
+                stream_output=False,
             ),
             # Submit for notarization a second time
             mock.call(
@@ -269,6 +270,7 @@ def test_credential_storage_failure_app(
                     "briefcase-macOS-DEADBEEF",
                 ],
                 check=True,
+                stream_output=False,
             ),
         ]
     )
@@ -326,6 +328,7 @@ def test_credential_storage_failure_dmg(package_command, first_app_dmg):
                     "briefcase-macOS-DEADBEEF",
                 ],
                 check=True,
+                stream_output=False,
             ),
         ]
     )
@@ -480,6 +483,7 @@ def test_notarize_unknown_credentials_after_storage(package_command, first_app_d
                     "briefcase-macOS-DEADBEEF",
                 ],
                 check=True,
+                stream_output=False,
             ),
             # Submit for notarization a second time
             mock.call(

diff --git a/tests/platforms/macOS/app/test_signing.py b/tests/platforms/macOS/app/test_signing.py
@@ -190,7 +190,10 @@ def test_no_identities(dummy_command):
 
     with pytest.raises(
         BriefcaseCommandError,
-        match=r"No code signing identities are available.",
+        match=(
+            r"No code signing identities are available: see "
+            r"https://briefcase.readthedocs.io/en/stable/how-to/code-signing/macOS.html"
+        ),
     ):
         dummy_command.select_identity()