Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on therubyracer #1591

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Remove the dependency on therubyracer #1591

merged 1 commit into from
Jul 19, 2018

Conversation

ignisf
Copy link
Contributor

@ignisf ignisf commented Jul 19, 2018

therubyracer has long been unmaintained which is causing both security and build
issues to go unfixed. As beef depends on it only to provide a JS runtime for
execjs, we can drop it and require users to install Node.js. execjs
automatically finds the node binary and uses it as a JS runtime.

This fixes #1478, #1045, #1046, #1249, #1374, #1377, #1395, #1396, #1428, #1429
This also fixes #1433, #1502, #1504, #1540, #1545, #1547

therubyracer has long been unmaintained which is causing both security and build
issues to go unfixed. As beef depends on it only to provide a JS runtime for
execjs, we can drop it and require users to install Node.js. execjs
automatically finds the node binary and uses it as a JS runtime.

This fixes #1478, #1045, #1046, #1249, #1374, #1377, #1395, #1396, #1428, #1429
This also fixes #1433, #1502, #1504, #1540, #1545, #1547
@ignisf
Copy link
Contributor Author

ignisf commented Jul 19, 2018

I am not able to run all tests due to the following error:

Errno::ENOENT: No such file or directory @ rb_sysopen - tmp/rk_beef_conf.yaml

@bcoles
Copy link
Collaborator

bcoles commented Jul 19, 2018

Yeah that test is poorly designed

@bcoles
Copy link
Collaborator

bcoles commented Jul 19, 2018

This should probably fix it:

mkdir tmp
cp config.yaml tmp/rk_beef_conf.yaml

Ideally the test should be fixed to not suck.

@bcoles bcoles merged commit f2d2fd6 into beefproject:master Jul 19, 2018
@bcoles
Copy link
Collaborator

bcoles commented Jul 19, 2018

Thanks

@blshkv
Copy link

blshkv commented Jul 22, 2018

guys in the bug above suggested to have a look at mini_racer. FYI

@bcoles bcoles self-assigned this Feb 19, 2019
@ignisf ignisf deleted the drop-therubyracer-dep branch May 20, 2019 15:33
@bcoles bcoles mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review therubyracer gem There was an error while trying to load the gem 'uglifier'
3 participants