Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Therubyracer #1789

Closed
jcrew99 opened this issue Dec 2, 2019 · 4 comments
Closed

Replacing Therubyracer #1789

jcrew99 opened this issue Dec 2, 2019 · 4 comments

Comments

@jcrew99
Copy link
Collaborator

jcrew99 commented Dec 2, 2019

This is an issue to try and replace therubyracer with another gem.
Therubyracer seems to have been causing problems for a while and if there is an alternative that would work and remove the issues therubyracer sometimes causes for people that would be helpful.
I am currently trying discourse/mini_racer for example, which seems to be more up to date.
I have been using mini_racer in place of therubyracer and havent seen any issues, but will note them down when seen.
If anyone has any ideas or methods that is more stable please put them down so we can discuss

@bcoles
Copy link
Collaborator

bcoles commented Dec 2, 2019

therubyracer was dropped in #1591 in favor of relying on NodeJS, but was latter re-added without explanation.

@jcrew99
Copy link
Collaborator Author

jcrew99 commented Dec 3, 2019

So it was removed on 2018-07-19 by Petko Bordjukov and added on 2019-09-26 by @passbe when the Rspec tests were merged. Ben is it fine for me to remove therubyracer again or is there a specific reason to have the gem? If so would using mini_racer be viable instead?

@jcrew99
Copy link
Collaborator Author

jcrew99 commented Dec 3, 2019

#1793

@jcrew99
Copy link
Collaborator Author

jcrew99 commented Dec 3, 2019

Ben confirmed that there is no conflicts so i removed it and am closing this issue.

@jcrew99 jcrew99 closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants