Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and fixes #6

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Tests and fixes #6

merged 4 commits into from
Dec 8, 2024

Conversation

clonder
Copy link
Contributor

@clonder clonder commented Nov 24, 2024

Changes Made

  1. Removed Unused Functions:

    • Deleted functions.get_columns and functions.get_score as they were unused in the codebase.
  2. Modernized Import Handling:

    • Updated src/kinex/resources/__init__.py to use the modern files() method from importlib.resources instead of the deprecated path() method.
  3. Fixed Sequence Handling:

    • Added PH_CAPITAL = "(PH)" in src/kinex/sequence.py to handle cases where seq.upper() with favorability=False resulted in invalid separators (e.g., (PH)), which were mistakenly filtered out.
  4. Improved Stability:

    • Added a check_zeros parameter to the 2x2 table implementation to prevent division by zero errors when shift_zeros=False.
  5. Improved fisher_statistics function:

    • Divided it into subfunctions for better testing and readability.
  6. Enhanced Test Coverage:

    • New Tests:
      • Added test cases for enrichment, sequence, score, and table2x2 modules.
    • Updated Tests:
      • Fixed and extended test coverage for kinex and io modules.

Fixes #7

@clonder clonder changed the title Tests Tests and fixes Nov 25, 2024
@alexandra-valeanu
Copy link
Collaborator

alexandra-valeanu commented Dec 5, 2024

Hey @clonder! Thank you for all the work!

I'll review the changes in the coming days and provide feedback.

@alexandra-valeanu alexandra-valeanu merged commit d065f90 into bedapub:main Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-sensitive separator filtering
2 participants