We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue In kinex.py:
kinex.py
if not phospho_priming: sequence = sequence.upper()
The sequence string is converted to uppercase, which affects any substrings used as separators. For example, (ph) becomes (PH).
In sequence.py:
sequence.py
class SequenceSeparator(Enum): ASTERISK = "*" PH = "(ph)" valid_patterns = get_valid_patterns(separator) if not any(pattern in sequence_string for pattern in valid_patterns): return False
The valid patterns, such as (ph) from SequenceSeparator, do not match the uppercase-transformed string, leading to invalid filtering.
(ph)
SequenceSeparator,
Example:
AAAAAAAGDS(ph)DSWDADAFSVEDPVR
AAAAAAAGDS(PH)DSWDADAFSVEDPVR.
Proposed Fix
If it is a valide issue, I added uppercase separator in #6 pull request!
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Issue
In
kinex.py
:The sequence string is converted to uppercase, which affects any substrings used as separators. For example, (ph) becomes (PH).
In
sequence.py
:The valid patterns, such as
(ph)
fromSequenceSeparator,
do not match the uppercase-transformed string, leading to invalid filtering.Example:
AAAAAAAGDS(ph)DSWDADAFSVEDPVR
AAAAAAAGDS(PH)DSWDADAFSVEDPVR.
Proposed Fix
If it is a valide issue, I added uppercase separator in #6 pull request!
The text was updated successfully, but these errors were encountered: