add tree view #1304
Closed
add tree view #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagebu
requested changes
Aug 21, 2021
There was a problem hiding this comment.
Thanks for the PR!
This doesn't pass the CI as you have barely added any types - could you try to fix that? The code that creates the folder tree should be tested. I'm not really keen to add the path-browserify dependency, I think for our case a splitting by regex might suffice - if not, you could turn the paths into lists of its elements and pass that to the frontend. And I think that the creation of the folder tree could be achieved by using the stratify function that already exists, that would shorten the new code a bit.
|
Closing this stale PR, happy to reopen if this is continued :) |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1137.
All functions are implemented in frontend.