-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tree view for source files in editor. #1137
add tree view for source files in editor. #1137
Conversation
Hi @xiaoniu-578fa6bff964d005, thanks for the PR :) I'm not willing to merge such a substantial change without any tests and I'm somewhat hesitant to merge such a big change for this feature at all. Could this maybe be implemented more succinctly by not rendering a full tree, but rather by just splitting the path into directory and filename and then just grouping by directory? I think that would already vastly reduce the visual clutter. |
Hi @yagebu, I am also not convinced that my design is the best approach. I would like to regard it as a mitigation of current difficulty and hopefully trigger the development of some serious solutions. Do you have any example of "splitting the path into directory and filename and then just grouping by directory"? |
Well, it would look like your example image, but instead of having a tree of directories it would just be a list of directories and under each directory the files in that directory would be listed. |
Does each directorey show the full path? Do we need to handle nested folders? |
Hey @xiaoniu-578fa6bff964d005, sorry for the long silence, I was on vacation and somewhat forgot about this.
I don't really have a strong opinion on this. I guess ignoring nested folders and showing the full path would be "good enough" without having to add about 150 lines of code. If you really want to implement this as a tree view, it should be done completely in the frontend. The |
I'm closing this stale PR. If you want to continue to work on this, feel free to reopen |
Sorry for the absence for almost one year. |
Implement #1136 .
Some Previews:
Some possible improvements:
sources
andlist_sources
.