tests: fix for windows #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
In relation to testing LevelDB changes, there are very few tests here, so there isn't a lot of coverage. Most of the tests are at the upstream source https://github.com/level/leveldown |
braydonf
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the hardcoded
dbpathvariable such that it works on non unix operating systems like Windows. It also fixes some linting errors in the tests.This is a precursor for my experimentation with upgrading LevelDB to the latest release. I have successfully synced bcoin using LevelDB 1.22 on Linux. I'd like to get some performance metrics before attempting to merge into
bdb. Looking at the LevelDB issues, it appears as if some critical bugs were fixed since 1.20.My work is here:
https://github.com/tynes/bdb/tree/leveldb-1.22
Note that the above git branch does not build on Windows yet and this PR will more easily allow me to test that it builds and operates as expected.