Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LevelDB update to v1.22 #10

Closed
wants to merge 2 commits into from
Closed

Conversation

braydonf
Copy link
Contributor

@braydonf braydonf commented Oct 9, 2019

No description provided.

@braydonf braydonf changed the title WIP LevelDB update to v1.22 LevelDB update to v1.22 Jan 29, 2020
@braydonf
Copy link
Contributor Author

I think we can hold off on this update until later, however I'll leave this open as example on what is necessary to upgrade, when ready.

@tynes
Copy link
Member

tynes commented Apr 30, 2020

I didn't realize that you had an open PR for this @braydonf

I think this is more important after seeing a bug in v1.20 about keys being lost during compaction.
See google/leveldb#339

This is a good precursor to make sure that it still builds on Windows #11

See my branch here:
https://github.com/tynes/bdb/tree/leveldb-1.22

@braydonf
Copy link
Contributor Author

I was about to reply in the other thread. Yeah I started this when investigating segmentation fault issues (with the bindings) that have since been fixed. Leveldown (upstream) still hasn't upgraded, however Bitcoin Core has as part of the latest release candidate.

@tynes
Copy link
Member

tynes commented Apr 30, 2020

I have a logfile of a bcoin sync with LevelDB 1.20 and another with 1.22, I'd like to dig into them to see if there were any major differences. I also think it would be straightforward to write a benchmark that indexes and reads a bunch of data in a deterministic way to see if there are performance differences.

Once I have it building on Windows (thanks for the merge here #11), I'll revisit this PR. I feel a lot more comfortable upgrading to 1.22 if Bitcoin Core is also planning on doing so.

@nodech nodech closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants