Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add Natspec comments for clarity #146

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Conversation

Aboudjem
Copy link
Contributor

Summary

Added NATSPEC comments to missing functions and updated the existing ones that were incomplete

Related Issue: #SMA-98

Change Type

  • Documentation Update

@linear
Copy link

linear bot commented Oct 13, 2023

SMA-98 Natspec Comments for All Functions

Ensure all functions have Natspec comments for better documentation and understanding.

@@ -51,7 +51,6 @@
"@typescript-eslint/eslint-plugin": "^5.30.5",
"@typescript-eslint/parser": "^5.30.5",
"chai": "^4.3.7",
"dotenv": "^16.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove dotenv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove it, it was duplicated on devdep

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@ankurdubey521
Copy link
Collaborator

Thanks a lot for this @Aboudjem !

@Aboudjem Aboudjem merged commit c741351 into develop Oct 16, 2023
2 checks passed
@Aboudjem Aboudjem deleted the features/SMA-98-natspec branch October 16, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants