Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🙈 Remove ignore linting rules #147

Merged
merged 3 commits into from
Oct 16, 2023
Merged

🙈 Remove ignore linting rules #147

merged 3 commits into from
Oct 16, 2023

Conversation

Aboudjem
Copy link
Contributor

Summary

Refactored code to minimize lint rule exceptions and overrides in smart contracts.

Related Issue: #SMA-159

Change Type

  • Refactor

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@linear
Copy link

linear bot commented Oct 13, 2023

SMA-159 Remove and Fix Ignored Linting Rules on Smart Contracts

Eliminate all ignored linting rules and resolve the linting errors. Also, re-enable previously disabled rules and fix them.

@livingrockrises livingrockrises merged commit 168a4db into features/SMA-98-natspec Oct 16, 2023
2 checks passed
@Aboudjem Aboudjem deleted the features/SMA-159-remove-ignore-lint branch October 25, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livingrockrises livingrockrises livingrockrises approved these changes

@ankurdubey521 ankurdubey521 ankurdubey521 approved these changes

@filmakarov filmakarov Awaiting requested review from filmakarov

@AmanRaj1608 AmanRaj1608 Awaiting requested review from AmanRaj1608

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aboudjem @ankurdubey521 @livingrockrises