18804 Filer - Regular Amalgamations

[vysakh-menon-aot]

Issue #: /bcgov/entity#18804

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[codecov]

Codecov Report

Attention: 284 lines in your changes are missing coverage. Please review.

Comparison is base (79511cd) 77.37% compared to head (8d7b6b2) 77.22%.
Report is 68 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2375      +/-   ##
==========================================
- Coverage   77.37%   77.22%   -0.15%     
==========================================
  Files         202      211       +9     
  Lines       11602    12391     +789     
  Branches     1961     2107     +146     
==========================================
+ Hits         8977     9569     +592     
- Misses       2043     2196     +153     
- Partials      582      626      +44     

Flag	Coverage Δ
entityfiler	80.35% <76.29%> (-0.05%)	⬇️
legalapi	76.66% <67.60%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
legal-api/src/legal_api/config.py	95.16% <100.00%> (+0.28%)	⬆️
legal-api/src/legal_api/core/filing.py	87.12% <100.00%> (+0.62%)	⬆️
legal-api/src/legal_api/core/filing_helper.py	50.00% <100.00%> (ø)
legal-api/src/legal_api/models/__init__.py	100.00% <100.00%> (ø)
...-api/src/legal_api/models/amalgamating_business.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/amalgamation.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/business.py	94.04% <100.00%> (+0.05%)	⬆️
legal-api/src/legal_api/models/dc_definition.py	90.69% <100.00%> (ø)
...l-api/src/legal_api/models/dc_revocation_reason.py	100.00% <100.00%> (ø)
legal-api/src/legal_api/models/filing.py	92.41% <ø> (ø)
... and 25 more

... and 3 files with indirect coverage changes

[sonarqubecloud]

Quality Gate failed

Failed conditions

17.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[argush3]

Nice work!