Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update image tags and resource allocation #26

Merged
merged 2 commits into from
Oct 10, 2024
Merged

chore: update image tags and resource allocation #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
579219e
chore: update img tags
bryce-mcmath Oct 10, 2024
2addb27
chore: adjust resource allocation to prevent hitting limits
bryce-mcmath Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devops/charts/server/values_dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ image:
# registry: ghcr.io
repository: bcgov/indy-vdr-proxy-server/server
# Overrides the image tag whose default is the chart appVersion.
tag: "342bdc4"
tag: "b340416"

env:
PORT: "3000"
Expand Down
12 changes: 6 additions & 6 deletions devops/charts/server/values_prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Default values for vdr-proxy prod deployment
namespace: c2a2c4-prod

replicaCount: 3
replicaCount: 2
Copy link
Member

@jleach jleach Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For prod the convention is usually 3 minimum. Maybe this is outdated and 2 is good enough so if you've read elsewhere that 2 is fine the LGTM. Two is fine for test and I often just use 1 or 2 in dev.


autoscaling:
enabled: true
minReplicas: 3
maxReplicas: 5
minReplicas: 2
maxReplicas: 3
targetCPUUtilizationPercentage: 80

podAnnotations: {}
Expand All @@ -18,7 +18,7 @@ image:
# registry: ghcr.io
repository: bcgov/indy-vdr-proxy-server/server
# Overrides the image tag whose default is the chart appVersion.
tag: "342bdc4"
tag: "b340416"

env:
PORT: "3000"
Expand All @@ -29,10 +29,10 @@ env:
resources:
requests:
memory: 300Mi
cpu: 50m
cpu: 40m
limits:
memory: 300Mi
cpu: 200m
cpu: 120m

imagePullSecrets:
- name: artifactory-regcred
Expand Down
4 changes: 2 additions & 2 deletions devops/charts/server/values_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ image:
# registry: ghcr.io
repository: bcgov/indy-vdr-proxy-server/server
# Overrides the image tag whose default is the chart appVersion.
tag: "342bdc4"
tag: "b340416"

env:
PORT: "3000"
Expand All @@ -32,7 +32,7 @@ resources:
cpu: 30m
limits:
memory: 300Mi
cpu: 200m
cpu: 120m

imagePullSecrets:
- name: artifactory-regcred
Expand Down
Loading