chore: update image tags and resource allocation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
jleach
requested changes
Oct 10, 2024
| @@ -1,12 +1,12 @@ | |||
| # Default values for vdr-proxy prod deployment | |||
| namespace: c2a2c4-prod | |||
|
|
|||
| replicaCount: 3 | |||
| replicaCount: 2 | |||
There was a problem hiding this comment.
For prod the convention is usually 3 minimum. Maybe this is outdated and 2 is good enough so if you've read elsewhere that 2 is fine the LGTM. Two is fine for test and I often just use 1 or 2 in dev.
jleach
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tags and lowering the resource allocation a bit so we don't hit limits even when max pods are used