update submission route #189
Conversation
… and store submitted payload instead of previous data
|
/gcbrun |
| @@ -94,6 +98,8 @@ def get_entity_submission(business_identifier: str): | |||
|
|
|||
| submission = SubmissionModel.find_by_business_identifier(business_identifier) | |||
| if submission: | |||
| if submission.submitted_payload is None or submission.submitted_payload == '': | |||
There was a problem hiding this comment.
Is there a need to set this on GET method ?
There was a problem hiding this comment.
We probably don't need it long term, I just didn't want to return no information for a field that SHOULD have information.
There was a problem hiding this comment.
I would remove it, as this is still all dev and no wrong data is in production.
There was a problem hiding this comment.
Yeah I would also prefer these 2 GET endpoints not set the submitted_payload
| @@ -75,12 +76,45 @@ def create_submission(submission_dict: dict, submitter_id: int) -> SubmissionMod | |||
|
|
|||
| """ | |||
| submission = SubmissionModel.find_by_business_identifier(submission_dict['businessIdentifier']) | |||
| if not submission: | |||
| submission = SubmissionModel() | |||
| submission.business_identifier = submission_dict['businessIdentifier'] | |||
There was a problem hiding this comment.
I think this line got accidentally merged incorrectly, we need to set identifier for submission too after creating new model.
| @@ -13,6 +13,7 @@ | |||
| from sqlalchemy import text | |||
There was a problem hiding this comment.
Can you add a test in here similar to 'test_post_plots' for the put? Ideally it would start with a realistic example of an SI and then the PUT would update an existing person with things like name, etc. and then also add a new person, and then it would verify the result is how we want the SI to look
| try: | ||
| user = UserModel.get_or_create_user_by_jwt(g.jwt_oidc_token_info) | ||
| account_id = request.headers.get('Account-Id', None) | ||
| submission = SubmissionModel.find_by_id(sub_id) |
There was a problem hiding this comment.
Do we have submission ID in the UI already, or do we need ticket/update to get that information ?
There was a problem hiding this comment.
We do have it in the UI already
*Issue:*bcgov/entity#22381
Description of changes:
Added a util function for deep_spread and created an update route for submissions (PUT /:id) Added unit tests for deep spread
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).