Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTR API: Redaction submissions #22381

Closed
kialj876 opened this issue Jul 22, 2024 · 2 comments
Closed

BTR API: Redaction submissions #22381

kialj876 opened this issue Jul 22, 2024 · 2 comments
Assignees
@BrandonSharratt
Labels
BTR Business Transparency Register

Comments

@kialj876
Copy link
Collaborator

kialj876 commented Jul 22, 2024 •
edited by mstanton1
Loading

Currently the backend overwrites the entire filing with the new submission. For submissions with redacted data, this will overwrite data with redacted values.

Solution after dev discussion

  • API
    • new put endpoint for this flow?
    • new column for untouched partial/edit submission
    • apply new changes by merging the previous filing with partial changes
      • planning to use dict spread, NOTE: does not work as we need for nested properties so it will need to do it for each nested piece of the filing
    • validation will happen after the changes are merged in

Redaction Rules: https://docs.google.com/spreadsheets/u/2/d/1Bde9cdmq3sS4eUk0f58GSP44k6Ry5xqT/edit?pli=1&gid=741929338#gid=741929338
@kialj876 kialj876 added the BTR Business Transparency Register label Jul 22, 2024
@mstanton1 mstanton1 changed the title BTR UI/API: Redaction submissions BTR API: Redaction submissions Aug 1, 2024
@BrandonSharratt BrandonSharratt self-assigned this Aug 14, 2024
@BrandonSharratt BrandonSharratt mentioned this issue Aug 19, 2024
Merged
@gunanagar
Copy link
Collaborator

@BrandonSharratt - Raised bug #23036 which is blocking the testing.

@gunanagar
Copy link
Collaborator

gunanagar commented Aug 29, 2024 •
edited
Loading

tested through postman. Will more testing once integrated to UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrandonSharratt BrandonSharratt

Labels
BTR Business Transparency Register
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BrandonSharratt @kialj876 @mstanton1 @gunanagar