Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23969 do not authorize button spinner disabled after clicking #701

Conversation

eason-pan-bc
Copy link
Collaborator

Issue #: /bcgov/entity#23969

Description of changes:

When clicking on either button, both 2 buttons will be disabled, and the clicked one will have a loading spinner.

  • To clearly communicate with users of the system status: something is being processed
  • To prevent users clicking on the same button multiple times

"Do Not Authorize" Button (After clicking)

Before:
image
After:
image

"Authorize" Button (After clicking)

Before:
image
After:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Copy link

sonarqubecloud bot commented Nov 6, 2024

@eason-pan-bc
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful solution!

Just a small comment from me but I'll approve now.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-701-0ym1ka4b.web.app

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍

@eason-pan-bc eason-pan-bc merged commit 9b07948 into bcgov:main Nov 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants