Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI: "Do Not Authorize" button should be spinner/disabled after clicking #23969

Closed
severinbeauvais opened this issue Oct 22, 2024 · 4 comments
Assignees
Labels
BTR Business Transparency Register bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 22, 2024

A feature was implemented by another team to use the To Do List to authorize / not authorize a user affiliation.

It was observed that clicking the "Do Not Authorize" button took a long time to process. The issue is that the button was not disabled during this delay, so the user could click it multiple times.

The solution is to use the button's "loading" state to both display a spinner and disable the authorize / not authorize buttons during the process.

@severinbeauvais severinbeauvais added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2 labels Oct 22, 2024
@severinbeauvais severinbeauvais changed the title Copy of Filings UI: spinner should pre-empt action button Filings UI: "Do Not Authorize" button should be spinner/disabled after clicking Oct 22, 2024
@severinbeauvais severinbeauvais added Dependency To highlight the dependency(intra team, external, third parties) BTR Business Transparency Register labels Oct 28, 2024
@davemck513 davemck513 added Entities - David A label to filter on the tickets for the Entities based team that David is PO for. and removed Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Oct 30, 2024
@eason-pan-bc eason-pan-bc self-assigned this Nov 5, 2024
@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Nov 5, 2024

@severinbeauvais Do we also want to make the "Authorize" button be spinner / disabled after clicking, to keep the behaviours consistent? Or just the "Do Not Authorize" button?

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 5, 2024

Yes, good catch 🚀

We want to:

  • let the user know that something is happening
  • prevent the user from double-clicking the button (or, if possible, start any other action that could pre-empt/break the current action)

@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Nov 6, 2024

Notes for QA

Tested in Dev

Works as expected:

  • When clicking on either button, both 2 buttons will be disabled, and the clicked one will have a loading spinner.
    • To clearly communicate with users of the system status: something is being processed
    • To prevent users clicking on the same button multiple times

image.png

How to reproduce this scenario

This UI displays in Account-B's entity page, when Account-A is requesting for authorization to manage a business from Account-B.

What you need
  • 2 regular user accounts (Account-A and Account-B)
  • have at least 1 incorporated business in one account (let's say Account-B has a business "BC1234567"
Steps:
  1. in the dashboard of Account-A, search for Account-B's business "BC1234567"
  2. then select "Request authorization from an account currently managing the business" and select "Manage This Business"image.png
  3. go to Account-B's dashboard, and find the business "BC1234567", and click "Manage Business", you will find the request in the To Do list.image.png

@vishnup0422
Copy link
Collaborator

vishnup0422 commented Nov 7, 2024

Followed the same steps to verify this ticket

Account1: Vishnu Dev
BC0883664

Account2: Vishnu Dev2

Submitted a Request for the Business from Account2.

Screenshot 2024-11-07 at 7.47.54 AM.png

Screenshot 2024-11-07 at 7.48.07 AM.png

Switch to Account1. Search for the Business and Click on Manage Business
We can see the Pending Request

Screenshot 2024-11-07 at 7.49.08 AM.png

Click on Do not Authorize button. The loading spinner comes in place of the button.

Private Zenhub Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register bug Something isn't working Dependency To highlight the dependency(intra team, external, third parties) Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Priority2
Projects
None yet
Development

No branches or pull requests

4 participants