Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter incorrectly reports disabled specs as failed #28

Closed
clayreimann opened this issue May 1, 2015 · 2 comments
Closed

Reporter incorrectly reports disabled specs as failed #28

clayreimann opened this issue May 1, 2015 · 2 comments

Comments

@clayreimann
Copy link

Specs like: it('should initalize with no errors'); cause spec-reporter to report a failure when a pending spec would be more appropriate.

@bcaudan
Copy link
Owner

bcaudan commented May 4, 2015

I can't reproduce the behaviour you describe...
This kind of spec are reported (by default or jasmine spec reporter) as:

  • with jasmine1: successful
  • with jasmine2: pending

I have used the example spec (npm run example) to test it.
Could you reproduce your issue with it?

@bcaudan
Copy link
Owner

bcaudan commented May 10, 2015

I finally succeed to reproduce this issue by focusing a spec:

describe('suite', function() {
  fit('should be executed', function() {
  });

  it('should be skipped', function() {
  });
});

Executed 1 of 2 specs SUCCESS (1 SKIPPED) in 0.042 secs.

So in v2.2.1, disabled specs are reported as skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants