Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled specs are reported as failed (as of Jasmine 2.3.x?) #38

Closed
pmowrer opened this issue May 26, 2015 · 4 comments
Closed

Disabled specs are reported as failed (as of Jasmine 2.3.x?) #38

pmowrer opened this issue May 26, 2015 · 4 comments

Comments

@pmowrer
Copy link

pmowrer commented May 26, 2015

After upgrading Jasmine from 2.1.1 to 2.3.1 (actually, Protractor did this for us, we cannot control the exact Jasmine version), disabled tests are reported as failed (i.e. xdescribe and xit).

Maybe its a bug in Jasmine itself? jasmine/jasmine#840

Sorry if double-reporting, I saw issue #28 but it made not explicit mention to xdescribe and xit.

@bcaudan
Copy link
Owner

bcaudan commented May 26, 2015

I've tried to reproduce this behaviour with:

  • protractor: 2.1.0 (framework: 'jasmine2')
  • jasmine-spec-reporter: 2.2.2

But xdescribe are reported as skipped and xitare reported as pending.

@pmowrer
Copy link
Author

pmowrer commented May 26, 2015

@bcaudan Sorry for wasting your time, mistakenly thought I had successfully upgraded to 2.2.2 but was still at 2.1.0. It works as expected in 2.2.2, except all the colors are gone 😮

@pmowrer pmowrer closed this as completed May 26, 2015
@bcaudan
Copy link
Owner

bcaudan commented May 26, 2015

are you using grunt-protractor-runner to launch your protractor tests? (#36)

@pmowrer
Copy link
Author

pmowrer commented May 26, 2015

No, I run it directly via node without any such wrappers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants