-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes after scalapb upgrade #1029
Conversation
I think it's a problem: CI fails with my local build fails with |
cc @Jamie5 I have a hunch that somewhere in the flag changes we lost some of the e2e tests we used to have |
btw, worst case I think we'll be able to add the problematic dep to the ignore targets of |
Also right now |
btw, it would also help to see the exact failure |
Closing in favor of #1030 which has a workaround for both issues. |
btw, this isn't time critical or anything, right? |
I can wait for #1030 to be merged |
Description
Build fixes for scala 2.12 and strict_deps enabled
Motivation
Build failures in my current project after last PR (#1026)