upgrading scalapb #1026

tian000 · 2020-03-31T08:13:20Z

Description

Upgrading scalapb to the latest version supported for Scala 2.11

Since this is a minor version upgrade in scalapb, there may be binary, and perhaps API incompatibilities.

Motivation

#667
So that I can use sparksql-scala and lenses without binary incompatibilities.

There are some tests that are failing can someone give me some pointers on why they are failing.

In particular, it looks like this target //test/proto:test_service-fast is failing to build but running bazel build //test/proto:test_service-fast says that the target does not exist.

Here's the full error message:

(base) nudomsak-pro:rules_scala napasudomask$ bazel build //test/...
DEBUG: /private/var/tmp/_bazel_napasudomask/27b4d30503e20c142fbe6514959c12c2/external/bazel_skylib/lib.bzl:30:1: WARNING: lib.bzl is deprecated and will go away in the future, please directly load the bzl file(s) of the module(s) needed as it is more efficient.
INFO: Analyzed 1303 targets (12 packages loaded, 1727 targets configured).
INFO: Found 1303 targets...
INFO: From scala //src/scala/scripts:scalapb_generator_lib [for host]:
warning: there were three deprecation warnings; re-run with -deprecation for details
one warning found
ERROR: /Users/napasudomask/gcode/rules_scala/test/proto/BUILD:102:1: scala //test/proto:test_service-fast failed (Exit 1)
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:4: error: type MethodDescriptor is not a member of package io.grpc
  val METHOD_TEST_METHOD1: _root_.io.grpc.MethodDescriptor[_root_.test.proto.test.TestRequest, _root_.test.proto.test2.TestResponse1] =
                                          ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:14: error: type MethodDescriptor is not a member of package io.grpc
  val METHOD_TEST_METHOD2: _root_.io.grpc.MethodDescriptor[_root_.test.proto.test.TestRequest, _root_.test.proto.test3.TestResponse2] =
                                          ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:24: error: type ServiceDescriptor is not a member of package io.grpc
  val SERVICE: _root_.io.grpc.ServiceDescriptor =
                              ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:5: error: object MethodDescriptor is not a member of package io.grpc
    _root_.io.grpc.MethodDescriptor.newBuilder()
                   ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:6: error: object MethodDescriptor is not a member of package io.grpc
      .setType(_root_.io.grpc.MethodDescriptor.MethodType.UNARY)
                              ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:7: error: object MethodDescriptor is not a member of package io.grpc
      .setFullMethodName(_root_.io.grpc.MethodDescriptor.generateFullMethodName("TestService", "TestMethod1"))
                                        ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:15: error: object MethodDescriptor is not a member of package io.grpc
    _root_.io.grpc.MethodDescriptor.newBuilder()
                   ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:16: error: object MethodDescriptor is not a member of package io.grpc
      .setType(_root_.io.grpc.MethodDescriptor.MethodType.UNARY)
                              ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:17: error: object MethodDescriptor is not a member of package io.grpc
      .setFullMethodName(_root_.io.grpc.MethodDescriptor.generateFullMethodName("TestService", "TestMethod2"))
                                        ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:25: error: object ServiceDescriptor is not a member of package io.grpc
    _root_.io.grpc.ServiceDescriptor.newBuilder("TestService")
                   ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:49: error: type Channel is not a member of package io.grpc
  class TestServiceBlockingStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceBlockingStub](channel, options) with TestServiceBlockingClient {
                                                        ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:49: error: type CallOptions is not a member of package io.grpc
  class TestServiceBlockingStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceBlockingStub](channel, options) with TestServiceBlockingClient {
                                                                                         ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:49: error: object CallOptions is not a member of package io.grpc
  class TestServiceBlockingStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceBlockingStub](channel, options) with TestServiceBlockingClient {
                                                                                                                      ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:49: error: Class io.grpc.Channel not found - continuing with a stub.
  class TestServiceBlockingStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceBlockingStub](channel, options) with TestServiceBlockingClient {
                                                                                                                                                   ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:51: error: Symbol 'type io.grpc.Channel' is missing from the classpath.
This symbol is required by 'value scalapb.grpc.ClientCalls.channel'.
Make sure that type Channel is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
A full rebuild may help if 'ClientCalls.class' was compiled against an incompatible version of io.grpc.
      _root_.scalapb.grpc.ClientCalls.blockingUnaryCall(channel, METHOD_TEST_METHOD1, options, request)
      ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:58: error: type Channel is not a member of package io.grpc
    override def build(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions): TestServiceBlockingStub = new TestServiceBlockingStub(channel, options)
                                               ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:58: error: type CallOptions is not a member of package io.grpc
    override def build(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions): TestServiceBlockingStub = new TestServiceBlockingStub(channel, options)
                                                                                ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:61: error: type Channel is not a member of package io.grpc
  class TestServiceStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceStub](channel, options) with TestService {
                                                ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:61: error: type CallOptions is not a member of package io.grpc
  class TestServiceStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceStub](channel, options) with TestService {
                                                                                 ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:61: error: object CallOptions is not a member of package io.grpc
  class TestServiceStub(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions = _root_.io.grpc.CallOptions.DEFAULT) extends _root_.io.grpc.stub.AbstractStub[TestServiceStub](channel, options) with TestService {
                                                                                                              ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:70: error: type Channel is not a member of package io.grpc
    override def build(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions): TestServiceStub = new TestServiceStub(channel, options)
                                               ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:70: error: type CallOptions is not a member of package io.grpc
    override def build(channel: _root_.io.grpc.Channel, options: _root_.io.grpc.CallOptions): TestServiceStub = new TestServiceStub(channel, options)
                                                                                ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:73: error: type ServerServiceDefinition is not a member of package io.grpc
  def bindService(serviceImpl: TestService, executionContext: scala.concurrent.ExecutionContext): _root_.io.grpc.ServerServiceDefinition =
                                                                                                                 ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:74: error: object ServerServiceDefinition is not a member of package io.grpc
    _root_.io.grpc.ServerServiceDefinition.builder(SERVICE)
                   ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:91: error: type Channel is not a member of package io.grpc
  def blockingStub(channel: _root_.io.grpc.Channel): TestServiceBlockingStub = new TestServiceBlockingStub(channel)
                                           ^
bazel-out/darwin-fastbuild/bin/test/proto/tmp2917373157101204084/test/proto/test_service/TestServiceGrpc.scala:93: error: type Channel is not a member of package io.grpc
  def stub(channel: _root_.io.grpc.Channel): TestServiceStub = new TestServiceStub(channel)
                                   ^
26 errors found
26 errors found
java.lang.RuntimeException: Build failed
        at io.bazel.rulesscala.scalac.ScalacProcessor.compileScalaSources(ScalacProcessor.java:256)
        at io.bazel.rulesscala.scalac.ScalacProcessor.processRequest(ScalacProcessor.java:76)
        at io.bazel.rulesscala.worker.GenericWorker.runPersistentWorker(GenericWorker.java:45)
        at io.bazel.rulesscala.worker.GenericWorker.run(GenericWorker.java:111)
        at io.bazel.rulesscala.scalac.ScalaCInvoker.main(ScalaCInvoker.java:41)
INFO: Elapsed time: 18.973s, Critical Path: 13.67s
INFO: 38 processes: 38 worker.
FAILED: Build did NOT complete successfully

ittaiz · 2020-04-01T04:28:05Z

The tests aren’t compiling, it’s not that they’re not passing.
Try bazel build //test:proto
It seems the packages have changed. It might be backward incompatible. Don’t know.

tian000 · 2020-04-01T16:03:03Z

@ittaiz thank's for the pointers. I was able to fix the build by adding new dependencies of the grpc-java project.

…pgrade

tian000 · 2020-04-06T06:54:12Z

This fixes #667

simuons

Looks good to me. Thanks.

tian000 · 2020-04-07T05:24:12Z

thanks @simuons. Looks like i need a thumbs up from @ittaiz before this can be merged.

ittaiz

LGTM as well.
Simonas knows this area as well

* upgrading scalapb * lint fix * fix checksum * fixed build and tests by including additional grpc dependencies

upgrading scalapb

f448061

tian000 requested a review from ittaiz as a code owner March 31, 2020 08:13

googlebot added the cla: yes label Mar 31, 2020

Napas added 2 commits March 31, 2020 01:15

lint fix

7d6c903

fix checksum

b242aa7

fixed build and tests by including additional grpc dependencies

743d3d5

Merge remote-tracking branch 'bazelbuild/master' into napas/scalapb-u…

f0fdf26

…pgrade

simuons approved these changes Apr 7, 2020

View reviewed changes

ittaiz approved these changes Apr 7, 2020

View reviewed changes

ittaiz merged commit 9c84950 into bazelbuild:master Apr 7, 2020

tian000 mentioned this pull request Apr 7, 2020

Upgrade to latest version of scalapb? #667

Closed

darl mentioned this pull request Apr 8, 2020

fixes after scalapb upgrade #1029

Closed

SocksDevil pushed a commit to SocksDevil/rules_scala that referenced this pull request Jul 6, 2020

upgrading scalapb (bazelbuild#1026)

f2c00e8

* upgrading scalapb * lint fix * fix checksum * fixed build and tests by including additional grpc dependencies

gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this pull request May 31, 2022

Upgrade JUnit to 4.13 (bazelbuild#1026)

c73490e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrading scalapb #1026

upgrading scalapb #1026

tian000 commented Mar 31, 2020 •

edited

Loading

ittaiz commented Apr 1, 2020

tian000 commented Apr 1, 2020

tian000 commented Apr 6, 2020

simuons left a comment

tian000 commented Apr 7, 2020

ittaiz left a comment

upgrading scalapb #1026

upgrading scalapb #1026

Conversation

tian000 commented Mar 31, 2020 • edited Loading

Description

Motivation

ittaiz commented Apr 1, 2020

tian000 commented Apr 1, 2020

tian000 commented Apr 6, 2020

simuons left a comment

Choose a reason for hiding this comment

tian000 commented Apr 7, 2020

ittaiz left a comment

Choose a reason for hiding this comment

tian000 commented Mar 31, 2020 •

edited

Loading