Update to nodejs rules 0.31.1 #87

gregmagolan · 2019-06-03T03:05:34Z

nodejs_binary entry_point is now a label. See release notes https://github.com/bazelbuild/rules_nodejs/releases/tag/0.31.0 for more info.

This commit is a pre-req to bazel-contrib/rules_nodejs#777

googlebot · 2019-06-03T03:05:39Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-06-05T16:22:40Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

jelbourn

Can you include something in the commit message that explains the context a bit more, especially around temporarily pointing to your fork?

gregmagolan · 2019-06-05T17:28:00Z

@jelbourn Should have explained better in the desc. This is not meant to be merged until the commit is changed to point to a rules_nodejs release so the commit to my fork is temporary. PR is here to test against CI and will be updated to rules_nodejs upstream before merging :)

googlebot · 2019-06-06T22:50:14Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-06-07T17:55:02Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

alexeagle · 2019-06-07T17:56:30Z

Note: this means that rules_sass users will need to update their rules_nodejs version in WORKSPACE along with the next sass release. might want to include that note in the release notes @nex3

nodejs_binary entry_point is now a label

googlebot · 2019-06-10T23:30:41Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

gregmagolan · 2019-06-10T23:32:02Z

README.md

@@ -34,10 +34,6 @@ rules_sass_dependencies()
 # Setup repositories which are needed for the Sass rules.
 load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories")
 sass_repositories()
-
-# Setup the NodeJS toolchain
-load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories")


node_repositories() is no longer explicitly since sass_repositories() calls yarn_install which will call node_repositories() if it has not already been called.

gregmagolan · 2019-06-10T23:32:33Z

WORKSPACE

@@ -5,9 +5,6 @@ load("//:package.bzl", "rules_sass_dependencies", "rules_sass_dev_dependencies")
 rules_sass_dependencies()
 rules_sass_dev_dependencies()

-load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories")


node_repositories() is no longer explicitly since sass_repositories() calls yarn_install which will call node_repositories() if it has not already been called.

gregmagolan · 2019-06-10T23:34:06Z

sass/sass_repositories.bzl


 def sass_repositories():
    """Set up environment for Sass compiler.
    """

+    # 0.31.1: entry_point attribute of rules_nodejs is now a label
+    check_rules_nodejs_version("0.31.1")


If a rules_sass user is explicitly installing build_bazel_rules_nodejs in their WORKSPACE then they'll need to update to at least version 0.31.1. If they are not explicitly installing it then rules_sass_dependencies() will install the correct version transitively.

googlebot · 2019-06-10T23:37:27Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

* rules_sass bazelbuild/rules_sass#87 has landed so can switch back to upstream * stardoc commit we were depending on has since been releases so can switch to a release archive of io_bazel

Now that bazelbuild/rules_sass#87 has landed

* update to upstream rules_sass commit now that bazelbuild/rules_sass#87 has landed (+2 squashed * entry_point attributes in rules_nodejs are now labels

* update to upstream rules_sass commit now that bazelbuild/rules_sass#87 has landed (+2 squashed * entry_point attributes in rules_nodejs are now labels * includes temporary post-install patch for @angular/bazel protractor rule which will get removed once that rule is updated in angular repo

* rules_sass bazelbuild/rules_sass#87 has landed so can switch back to upstream * stardoc commits we were depending on have since been releases so can switch to a release archive of io_bazel & io_bazel_skydoc

* update to upstream rules_sass commit now that bazelbuild/rules_sass#87 has landed (+2 squashed * entry_point attributes in rules_nodejs are now labels * includes temporary post-install patch for @angular/bazel protractor rule which will get removed once that rule is updated in angular repo

* rules_sass bazelbuild/rules_sass#87 has landed so can switch back to upstream * stardoc commits we were depending on have since been releases so can switch to a release archive of io_bazel & io_bazel_skydoc

gregmagolan requested review from davidzchen, jelbourn and nex3 as code owners June 3, 2019 03:05

googlebot added the cla: no label Jun 3, 2019

gregmagolan force-pushed the manekinekko.rules-nodejs-entry-point branch from df0fdb9 to d968be6 Compare June 3, 2019 03:06

gregmagolan mentioned this pull request Jun 3, 2019

Add support for Label in nodejs_binary and rollup_bundle entry_point bazel-contrib/rules_nodejs#777

Merged

12 tasks

alexeagle added cla: yes and removed cla: no labels Jun 5, 2019

jelbourn reviewed Jun 5, 2019

View reviewed changes

gregmagolan force-pushed the manekinekko.rules-nodejs-entry-point branch from d968be6 to e47f9f1 Compare June 6, 2019 22:50

googlebot added cla: no and removed cla: yes labels Jun 6, 2019

gregmagolan changed the title ~~WIP: Update nodejs_binary entry points to labels~~ Update to nodejs rules 0.31.0 Jun 6, 2019

gregmagolan changed the title ~~Update to nodejs rules 0.31.0~~ WIP: Update to nodejs rules 0.31.0 Jun 6, 2019

gregmagolan force-pushed the manekinekko.rules-nodejs-entry-point branch from e47f9f1 to d033c0f Compare June 7, 2019 16:09

gregmagolan changed the title ~~WIP: Update to nodejs rules 0.31.0~~ Update to nodejs rules 0.31.1 Jun 7, 2019

alexeagle added cla: yes and removed cla: no labels Jun 7, 2019

alexeagle approved these changes Jun 7, 2019

View reviewed changes

Update to nodejs rules 0.31.1

50493db

nodejs_binary entry_point is now a label

gregmagolan force-pushed the manekinekko.rules-nodejs-entry-point branch from d033c0f to 50493db Compare June 10, 2019 23:30

googlebot added cla: no and removed cla: yes labels Jun 10, 2019

gregmagolan commented Jun 10, 2019

View reviewed changes

alexeagle approved these changes Jun 10, 2019

View reviewed changes

alexeagle added cla: yes and removed cla: no labels Jun 10, 2019

alexeagle merged commit 9a00e55 into bazelbuild:master Jun 10, 2019

gregmagolan mentioned this pull request Jun 11, 2019

build: update dev dependencies bazel-contrib/rules_nodejs#840

Merged

gregmagolan added a commit to gregmagolan/angular-bazel-example that referenced this pull request Jun 11, 2019

Update to upstream rules_sass commit

255bc20

Now that bazelbuild/rules_sass#87 has landed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to nodejs rules 0.31.1 #87

Update to nodejs rules 0.31.1 #87

gregmagolan commented Jun 3, 2019 •

edited

Loading

googlebot commented Jun 3, 2019

googlebot commented Jun 5, 2019

jelbourn left a comment

gregmagolan commented Jun 5, 2019

googlebot commented Jun 6, 2019

googlebot commented Jun 7, 2019

alexeagle commented Jun 7, 2019

googlebot commented Jun 10, 2019

gregmagolan Jun 10, 2019

gregmagolan Jun 10, 2019

gregmagolan Jun 10, 2019 •

edited

Loading

googlebot commented Jun 10, 2019

Update to nodejs rules 0.31.1 #87

Update to nodejs rules 0.31.1 #87

Conversation

gregmagolan commented Jun 3, 2019 • edited Loading

googlebot commented Jun 3, 2019

googlebot commented Jun 5, 2019

jelbourn left a comment

Choose a reason for hiding this comment

gregmagolan commented Jun 5, 2019

googlebot commented Jun 6, 2019

googlebot commented Jun 7, 2019

alexeagle commented Jun 7, 2019

googlebot commented Jun 10, 2019

gregmagolan Jun 10, 2019

Choose a reason for hiding this comment

gregmagolan Jun 10, 2019

Choose a reason for hiding this comment

gregmagolan Jun 10, 2019 • edited Loading

Choose a reason for hiding this comment

googlebot commented Jun 10, 2019

gregmagolan commented Jun 3, 2019 •

edited

Loading

gregmagolan Jun 10, 2019 •

edited

Loading