Skip to content

Commit

Permalink
feat: update rules_nodejs
Browse files Browse the repository at this point in the history
  • Loading branch information
manekinekko authored and gregmagolan committed Jun 3, 2019
1 parent fe850d4 commit df0fdb9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
5 changes: 3 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ load("//:package.bzl", "rules_sass_dependencies", "rules_sass_dev_dependencies")
rules_sass_dependencies()
rules_sass_dev_dependencies()

load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories")
node_repositories()
load("@build_bazel_rules_nodejs//:package.bzl", "rules_nodejs_dev_dependencies")

rules_nodejs_dev_dependencies()

load("//:defs.bzl", "sass_repositories")
sass_repositories()
Expand Down
5 changes: 3 additions & 2 deletions package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@ def _include_if_not_defined(repo_rule, name, **kwargs):

def rules_sass_dependencies():
# Since we use the Dart version of Sass, we need to be able to run NodeJS binaries.
# TODO(gregmagolan): update to upstream once commit below lands
_include_if_not_defined(
http_archive,
name = "build_bazel_rules_nodejs",
url = "https://github.com/bazelbuild/rules_nodejs/releases/download/0.30.1/rules_nodejs-0.30.1.tar.gz",
sha256 = "abcf497e89cfc1d09132adfcd8c07526d026e162ae2cb681dcb896046417ce91",
urls = ["https://github.com/gregmagolan/rules_nodejs/archive/fdac52569aad207efee584b677024edf260d1c25.zip"],
strip_prefix = "rules_nodejs-fdac52569aad207efee584b677024edf260d1c25"
)

# Dependencies from the NodeJS rules. We don't want to use the "package.bzl" dependency macro
Expand Down
2 changes: 1 addition & 1 deletion sass/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports_files([
# Executable for the sass_binary rule
nodejs_binary(
name = "sass",
entry_point = "sass/sass.js",
entry_point = "@build_bazel_rules_sass_deps//node_modules/sass:sass.js",
install_source_map_support = False,
data = [
"@build_bazel_rules_sass_deps//sass",
Expand Down

0 comments on commit df0fdb9

Please sign in to comment.