Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on spectral #2964

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove dependency on spectral #2964

merged 1 commit into from
Nov 5, 2024

Conversation

dzbarsky
Copy link
Contributor

It's only used for 2 test cases and we can just not use it.

@dzbarsky dzbarsky mentioned this pull request Oct 27, 2024
Closed
@dzbarsky dzbarsky force-pushed the zbarsky/spectral branch 2 times, most recently from 8e90082 to cc07bf6 Compare October 28, 2024 05:16
@dzbarsky
Copy link
Contributor Author

@illicitonion want to take a look?

illicitonion
illicitonion approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion added this pull request to the merge queue Nov 5, 2024
Merged via the queue into bazelbuild:main with commit ef61939 Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @illicitonion