Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off default features of spectral, … #2953

Conversation

sthornington
Copy link
Contributor

@sthornington sthornington commented Oct 21, 2024

spectral is 8 years old, and depends optionally on an ancient version of num, which depends on rustc_serialize, which is deprecated and a security risk.

…ds on num, which depends on rustc_serialize, which is deprecated and a security risk
@sthornington
Copy link
Contributor Author

The build error seems transient but I can't see immediately how to retry it myself.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For the future, pushing an empty commit will kick CI into a rerun.

@dzbarsky
Copy link
Contributor

I think we can do #2964 instead, wdyt?

@sthornington
Copy link
Contributor Author

Doesn't matter to me :)

@sthornington
Copy link
Contributor Author

Can we please try to get this in for the next release?

@UebelAndre
Copy link
Collaborator

Can we please try to get this in for the next release?

Isn't this resolved by #2964 ?

@sthornington
Copy link
Contributor Author

Ah yes it is, I hadn't checked that this morning. I'll close this now.

auto-merge was automatically disabled November 5, 2024 18:18

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants