-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a Source::parse arm for sparse repos (keeping it in the scheme). … #2950
add a Source::parse arm for sparse repos (keeping it in the scheme). … #2950
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I wrote a test for it, but was unable to run it - cargo test seemed to want some runfiles stuff and looking at that in crates.io lead me to believe that these things are not able to be tested from within cargo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much!
Thanks, let me know if there is anything else for me to do to get this merged! |
Thanks everyone for getting this in. Can I ask for a point release which includes this, or when is 0.53.1 otherwise planned? Or can I do start it myself? Thanks again. |
Proc macro resolution wasn't working properly for sparse repos. This fixes #2938.