Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source::parse doesn't recognize sparse scheme? #2938

Closed
sthornington opened this issue Oct 15, 2024 · 1 comment · Fixed by #2950
Closed

Source::parse doesn't recognize sparse scheme? #2938

sthornington opened this issue Oct 15, 2024 · 1 comment · Fixed by #2950

Comments

@sthornington
Copy link
Contributor

Our github and local crate repository mirrors are using the sparse scheme, but I suspect that copy_project_with_explicit_deps_on_all_transitive_proc_macros is failing on this inside Source::parse:

Caused by:
    0: Failed to copy project with proc macro deps made direct
    1: Couldn't parse source "sparse+https://artifactory.london.quadraturecapital.com/artifactory/api/cargo/cargo-remote/index/": Didn't recognise scheme

Am I missing something about how this is supposed to work?
@sthornington sthornington mentioned this issue Oct 19, 2024
Open
@sthornington
Copy link
Contributor Author

Will have a simple PR for this by Monday.

sthornington added a commit to sthornington/rules_rust that referenced this issue Oct 19, 2024
@sthornington
add a Source::parse arm for sparse repos (keeping it in the scheme). f…
709aa10 
…ixes bazelbuild#2938
@sthornington sthornington mentioned this issue Oct 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 20, 2024
@sthornington @illicitonion
add a Source::parse arm for sparse repos (keeping it in the scheme). … (
60141ec 
#2950)

Proc macro resolution wasn't working properly for sparse repos. This
fixes #2938.

---------

Co-authored-by: Daniel Wagner-Hall <[email protected]>
Co-authored-by: Daniel Wagner-Hall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a Source::parse arm for sparse repos (keeping it in the scheme). … sthornington/rules_rust
1 participant
@sthornington