Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make windows a supported host platform #838

Open
hlopko opened this issue Jul 15, 2021 · 8 comments
Open

Make windows a supported host platform #838

hlopko opened this issue Jul 15, 2021 · 8 comments
Labels

Comments

@hlopko
Copy link
Member

hlopko commented Jul 15, 2021

From #832 (comment)

image

@hlopko
Copy link
Member Author

hlopko commented Jul 15, 2021

CC @illicitonion

@UebelAndre
Copy link
Collaborator

Oh man, I have like, zero context for Windows... If it's on me to add support for it then it's gonna take a while 😅

Outside help would be extremely welcomed

@illicitonion
Copy link
Collaborator

I'm definitely not well-placed to help with this either :)

@UebelAndre
Copy link
Collaborator

@hlopko perhaps we could find an additional maintainer with some solid windows experience?

@kwonoj
Copy link
Contributor

kwonoj commented Jul 16, 2021

Sorry for random chime in, daily windows user and highly interested in this proj. (sadly not daily user of this rule).

Do we know what exactly aren't working / and what are the requirements to establish this goal? I'm curious if there's some step-by-step goals can gradually move over, or there is a major blockers that requires some fundamental changes to move forward.

@UebelAndre
Copy link
Collaborator

Hello! Super excited to hear there's interest in windows support 😄

For starters, there are some disabled targets (#613, #614, #615, #617, #618) which should be enabled to have parity with other platforms. That'd be the best place to start.

Following that, there are some under tested features (#540, as just an example) which would need to be investigated to make sure the appropriate feature set was supported on windows. I think these will either be uncovered in enabling the rest of the targets in CI or we'll need to add some targets to run in CI across all platforms.

At the end of the day though, if you're interested in the project definitely try to do some fun stuff with the rules on the platform. This is what got me so involved in the first place and am happy to support "Rustacean"'s quest to add more support for Rust to Bazel 🦀

@hlopko
Copy link
Member Author

hlopko commented Jul 19, 2021

Thanks @kwonoj! Let us know if you need any further help.

In general, I'll say that the fact that a platform is not supported doesn't mean we don't care. We're happy for all contributions and we will not intentionally break existing usecases. It just means we don't have the expertise (so we may break things unintentionally, or we may design solutions in a way that makes them unsuitable for Widows) or capacity to effectively resolve issues of Windows users.

Fixing all those issues is a great start, but I'd only want to "officially" support Windows if there is expertise and capacity to help users on Windows in the maintainers team.

@UebelAndre
Copy link
Collaborator

I have no windows knowledge. Unassigned myself as I can't really offer much value here. I do think it would be valuable to have windows support but I feel largely that Bazel ignores Windows thus it's unbearable difficult to deal with windows in Bazel Rules repositories. If ever there's a part with vested interest in Bazel and windows experience I would defer to them in how to improve support for the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants