Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable //test/test_env on Windows CI #613

Closed
hlopko opened this issue Feb 26, 2021 · 0 comments · Fixed by #842
Closed

Enable //test/test_env on Windows CI #613

hlopko opened this issue Feb 26, 2021 · 0 comments · Fixed by #842
Labels
good first issue help wanted maintenance windows

Comments

@hlopko
Copy link
Member

hlopko commented Feb 26, 2021

Since #612 we test more stuff on Windows, we don't test everything though. //test/test_env is currently disabled in .bazelci/presubmit.yml.

Feel free to comment on this issue if you want to know more or you want to give it a shot. We are happy to talk or help :)

How to fix when you don't have a Windows machine:

  1. delete the line with - "-//test/test_env/..."
  2. upload a draft PR
  3. see the CI failure
  4. try to fix it

How to fix when you do have a Windows machine:

  1. Try to repro the failure localy
  2. Fix it
  3. upload the PR :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted maintenance windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test_env): export canonical CARGO_BIN_EXE env variable
1 participant
@hlopko