FR: Runtime linking support for multiple platforms

[UebelAndre]

Edit

This has been issue has been turned into a feature request. The rules should support runtime linking on multiple platforms (more than just linux).

Original

Can anyone explain why this is the case?

rules_rust/rust/private/rustc.bzl

Lines 758 to 762 in 22d6730

	if toolchain.os != "linux":
	fail("Runtime linking is not supported on {}, but found {}".format(
	toolchain.os,
	dep_info.transitive_dylibs,
	))

Looking back at #121 and then #61 there doesn't seem to be anything calling out that this is specific to linux other than the fact that the PR was only scoped to linux.

Is this still correct that only this behavior is only possible on linux? If so, why is linux the only platform that can do this? If not, what would be the risk in expanding this to other platforms?

(hoping @mfarrugi might know since they appear to have been the original author)

[mfarrugi]

I didn't have the motivation, knowledge, or resources to implement dynamic linking support outside of Linux.

…

On Mon, Dec 21, 2020, 10:54 UebelAndre ***@***.***> wrote: Can anyone explain why this is the case? https://github.com/bazelbuild/rules_rust/blob/22d67305d80fbc1f0f3e959b3d520e908cf7f9aa/rust/private/rustc.bzl#L758-L762 Looking back at #121 <#121> and then #61 <#61> there doesn't seem to be anything calling out that this is specific to linux other than the fact that the PR was only scoped to linux. Is this still correct that only this behavior is only possible on linux? If so, why is linux the only platform that can do this? If not, what would be the risk in expanding this to other platforms? (hoping @mfarrugi <https://github.com/mfarrugi> might know since they appear to have been the original author) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#540>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAROG6E6D66SCECTUCZJSOLSV5VUNANCNFSM4VEMSSYQ> .

[UebelAndre]

Good to know, thanks. I updated this ticket to be a feature request for that then, so people are more aware of this. I don't think it'd be a lot of work to add support on MacOS but I'm not sure about Windows. Anywho, hope people find this issue useful. Thanks @mfarrugi for your response 🙏