Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip3_import #256

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Add pip3_import #256

merged 4 commits into from
Nov 15, 2019

Commits on Nov 11, 2019

  1. Add pip3_import

    This adds two repo rule macros, `pip2_import` and `pip3_import`, as wrappers
    around `pip_import` that set `python_interpreter` to "python2" and "python3"
    respectively. The latter is important for requesting the Python 3 version of a
    package, since the `pip_import` rule invokes "python", which is Python 2 on
    most systems.
    
    piptool.py is updated to prefix the names of the wheel repos (an implementation
    detail of rules_python) with the name given to `pip_import`. This is needed to
    avoid shadowing wheel repos when the same wheel name is used by separate
    `pip_import` invocations -- in particular when the same wheel is used for both
    PY2 and PY3. (Thanks to @joshclimacell for pointing this detail out in
    his prototype 90a70d5.)
    
    Regenerated the .par files and docs.
    brandjon committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0a69508 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Remove pip2_import

    brandjon committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    319f7f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Update README for packaging rules

    Better explain the structure of the packaging rules. Mention pip3_import and
    concerns around versioning and hermeticity. Clarify that users shouldn't
    depend on wheel repo names and recommend requirement() syntax for extras. Add
    an announcement about `pip3_import` support.
    
    Also add backticks to filenames.
    brandjon committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    266f73c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Update announcement date

    brandjon committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    ac536c1 View commit details
    Browse the repository at this point in the history