Add pip3_import #256
Add pip3_import #256
Conversation
This adds two repo rule macros, `pip2_import` and `pip3_import`, as wrappers around `pip_import` that set `python_interpreter` to "python2" and "python3" respectively. The latter is important for requesting the Python 3 version of a package, since the `pip_import` rule invokes "python", which is Python 2 on most systems. piptool.py is updated to prefix the names of the wheel repos (an implementation detail of rules_python) with the name given to `pip_import`. This is needed to avoid shadowing wheel repos when the same wheel name is used by separate `pip_import` invocations -- in particular when the same wheel is used for both PY2 and PY3. (Thanks to @joshclimacell for pointing this detail out in his prototype 90a70d5.) Regenerated the .par files and docs.
python/pip.bzl
Outdated
| # We don't advertise "Use this for PY2 programs" because it's not clear | ||
| # whether this alias is always available, and on most (but not all) systems | ||
| # `python` is Python 2 anyway. | ||
| pip_import(python_interpreter = "python2", **kwargs) |
There was a problem hiding this comment.
IIRC macOS has python and python2.7 but not python2, right?
I was ambivalent about whether to add pip2_import at all, or just leave that use case to pip_import (with or without a custom python_interpreter attr). I guess it's not ideal to encourage people to switch Python 2 deps to use pip2_import and thereby break mac users by default.
I suppose we could make this macro smarter to detect what platform it's running on and choose a different default. Thoughts?
There was a problem hiding this comment.
Correct. Yea I think related to bazelbuild/bazel#9402 it would be safe to default this to python2.7 on macOS, but I agree that this isn't a huge issue since this still provides complete customizability for users
There was a problem hiding this comment.
I'm going to revert the addition of pip2_import for the purposes of this PR. Filed #258 to track the feature of pip_import reliably detecting a suitable Python interpreter.
Better explain the structure of the packaging rules. Mention pip3_import and concerns around versioning and hermeticity. Clarify that users shouldn't depend on wheel repo names and recommend requirement() syntax for extras. Add an announcement about `pip3_import` support. Also add backticks to filenames.
|
@aiuto This adds a wrapper around the existing It also changes repo naming behavior, which breaks users who depended directly on wheel repos rather than going through the helper function as an intermediary. I think we'd like to release this functionality in a 0.0.2 release for inclusion in the federation for Bazel 2.0. |
Add
pip3_importas a macro built on the newpython_interpreterattribute topip_import.Also change canonical wheel repo naming to include the
pip_importname, so the same wheel can be named by multiplepip_imports.Update README, regenerate docs and tools.
Thanks go out to the authors of similar PRs #179, #85, and #216.
Fixes #33 (yaml import problem).
Fixes #165 (documentation request).
Closes #85 (similar PR).
Closes #179 (similar PR).
Fixes #249 (feature tracking bug).