Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(whl_library): avoid excessive report_progress() messages #2280

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix(whl_library): avoid excessive report_progress() messages #2280

merged 3 commits into from
Oct 9, 2024

Conversation

mattnworb
Copy link
Contributor

@mattnworb mattnworb commented Oct 8, 2024 •
edited by rickeylev
Loading

With the current behavior, we see really long progress messages in the console like

Running whl_library.ResolveRequirement(foobar_pip_deps_regex, regex==2023.12.25     --hash=sha256:0694219a1d54336fd0445ea3\
82d49d36882415c0134ee1e8332afd1529f0baa5
<many more lines of --hash values>

This spams the console and isn't very useful.

To fix, only print up to the first white space, which captures the important information
(e.g. "regex==2024.12.25") and is brief.

Closes #2206

@mattnworb
whl_library: avoid excessive report_progress() messages
fd8b3f8 
should close bazelbuild#2206

with current behavior, we see really long progress messages in the
console like

```
Running whl_library.ResolveRequirement(foobar_pip_deps_regex, regex==2023.12.25     --hash=sha256:0694219a1d54336fd0445ea3\
82d49d36882415c0134ee1e8332afd1529f0baa5     --hash=sha256:086dd15e9435b393ae06f96ab69ab2d333f5d65cbe65ca5a3ef0ec9564dfe770     --hash=sha256:094ba3\
86bb5c01e54e14434d4caabf6583334090865b23ef58e0424a6286d3dc     --hash=sha256:09da66917262d9481c719599116c7dc0c321ffcec4b1f510c4f8a066f8768105     --\
hash=sha256:0ecf44ddf9171cd7566ef1768047f6e66975788258b1c6c6ca78098b95cf9a3d     --hash=sha256:0fda75704357805eb953a3ee15a2b240694a9a514548cd49b3c51\
24b4e2ad01b     --hash=sha256:11a963f8e25ab5c61348d090bf1b07f1953929c13bd2309a0662e9ff680763c9     --hash=sha256:150c39f5b964e4d7dba46a7962a088fbc91\
f06e606f023ce57bb347a3b2d4630     --hash=sha256:1b9d811f72210fa9306aeb88385b8f8bcef0dfbf3873410413c00aa94c56c2b6     --hash=sha256:1e0eabac536b4cc7f\
57a5f3d095bfa557860ab912f25965e08fe1545e2ed8b4c     --hash=sha256:22a86d9fff2009302c440b9d799ef2fe322416d2d58fc124b926aa89365ec482     --hash=sha256\
:22f3470f7524b6da61e2020672df2f3063676aff444db1daa283c2ea4ed259d6     --hash=sha256:263ef5cc10979837f243950637fffb06e8daed7f1ac1e39d5910fd29929e489a\
     --hash=sha256:283fc8eed679758de38fe493b7d7d84a198b558942b03f017b1f94dda8efae80     --hash=sha256:29171aa128da69afdf4bde412d5bedc335f2ca8fcfe448\
...
```
@mattnworb mattnworb changed the title whl_library: avoid excessive report_progress() messages fix(whl_library): avoid excessive report_progress() messages Oct 8, 2024
@mattnworb mattnworb requested a review from rickeylev as a code owner October 8, 2024 19:31
@mattnworb mattnworb mentioned this pull request Oct 8, 2024
Closed
rickeylev
rickeylev approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@rickeylev rickeylev added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@mattnworb
Copy link
Contributor Author

seems like the status check errors on the merge queue are transient errors? i'm not too familiar with the setup


# Updating existing repository mirror to find commit 65f8116d93e96b98acf0b9d4085656ad5aa3d352
$ git --git-dir /var/lib/gitmirrors/https---github-com-bazelbuild-rules-python-git fetch origin gh-readonly-queue/main/pr-2280-84ff5777421c336f1cf1329a3ff0a5754b5bbf47
fatal: couldn't find remote ref gh-readonly-queue/main/pr-2280-84ff5777421c336f1cf1329a3ff0a5754b5bbf47
⚠️ Warning: Checkout failed! getting/updating git mirror: exit status 128 (Attempt 1/3 Retrying in 2s)

@rickeylev rickeylev added this pull request to the merge queue Oct 8, 2024
@rickeylev
Copy link
Collaborator

Yeah, looks like a network flake. Re-queued.

Merged via the queue into bazelbuild:main with commit ca0b27a Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

@aignas aignas Awaiting requested review from aignas aignas is a code owner

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release 0.35.0 has spammy output
2 participants
@mattnworb @rickeylev