-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 0.35.0 has spammy output #2206
Comments
Ah right. That The intent here was to have it show what package and version it was resolving, not the entire set of hashes (that's a bit much) |
Glad it's not more complicated. Is the fix obvious to you? |
I think just snip off the Something like:
around L247 Happy to approve a PR |
should close bazelbuild#2206 with current behavior, we see really long progress messages in the console like ``` Running whl_library.ResolveRequirement(foobar_pip_deps_regex, regex==2023.12.25 --hash=sha256:0694219a1d54336fd0445ea3\ 82d49d36882415c0134ee1e8332afd1529f0baa5 --hash=sha256:086dd15e9435b393ae06f96ab69ab2d333f5d65cbe65ca5a3ef0ec9564dfe770 --hash=sha256:094ba3\ 86bb5c01e54e14434d4caabf6583334090865b23ef58e0424a6286d3dc --hash=sha256:09da66917262d9481c719599116c7dc0c321ffcec4b1f510c4f8a066f8768105 --\ hash=sha256:0ecf44ddf9171cd7566ef1768047f6e66975788258b1c6c6ca78098b95cf9a3d --hash=sha256:0fda75704357805eb953a3ee15a2b240694a9a514548cd49b3c51\ 24b4e2ad01b --hash=sha256:11a963f8e25ab5c61348d090bf1b07f1953929c13bd2309a0662e9ff680763c9 --hash=sha256:150c39f5b964e4d7dba46a7962a088fbc91\ f06e606f023ce57bb347a3b2d4630 --hash=sha256:1b9d811f72210fa9306aeb88385b8f8bcef0dfbf3873410413c00aa94c56c2b6 --hash=sha256:1e0eabac536b4cc7f\ 57a5f3d095bfa557860ab912f25965e08fe1545e2ed8b4c --hash=sha256:22a86d9fff2009302c440b9d799ef2fe322416d2d58fc124b926aa89365ec482 --hash=sha256\ :22f3470f7524b6da61e2020672df2f3063676aff444db1daa283c2ea4ed259d6 --hash=sha256:263ef5cc10979837f243950637fffb06e8daed7f1ac1e39d5910fd29929e489a\ --hash=sha256:283fc8eed679758de38fe493b7d7d84a198b558942b03f017b1f94dda8efae80 --hash=sha256:29171aa128da69afdf4bde412d5bedc335f2ca8fcfe448\ ... ```
opened #2280 for this |
With the current behavior, we see really long progress messages in the console like ``` Running whl_library.ResolveRequirement(foobar_pip_deps_regex, regex==2023.12.25 --hash=sha256:0694219a1d54336fd0445ea3\ 82d49d36882415c0134ee1e8332afd1529f0baa5 <many more lines of --hash values> ``` This spams the console and isn't very useful. To fix, only print up to the first white space, which captures the important information (e.g. "regex==2024.12.25") and is brief. Closes #2206
In a recent release (I think 0.35.0), we get a lot more output when we
bazel build
. It spams the terminal. I'm not sure if this mainly affects bigger corporate repos with lots of dependencies, or if it also affects smaller projcts.I see something like:
Looks like the relevant code is
mrctx.report_progress("Running {}".format(op))
in https://github.com/bazelbuild/rules_python/blob/main/python/private/repo_utils.bzl#L139op_tmpl = "whl_library.ResolveRequirement({name}, {requirement})"
inrules_python/python/private/pypi/whl_library.bzl
Line 243 in fcd1d5e
desired behavior
Make the output much shorter, preferably fitting into one line.
The text was updated successfully, but these errors were encountered: