Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write all string attributes to files rather than passing on the command line #214

Closed
aiuto opened this issue Aug 7, 2020 · 0 comments · Fixed by #470
Closed

Write all string attributes to files rather than passing on the command line #214

aiuto opened this issue Aug 7, 2020 · 0 comments · Fixed by #470
Labels
bug help wanted P3 An issue that we are not working on but will review quarterly

Comments

@aiuto
Copy link
Collaborator

aiuto commented Aug 7, 2020 •
edited
Loading

Any attribute which could be beyond Latin-1 has to be handled in a portable way. Currently, there are problems with elements like pkg_deb.description. When passed on a command line in Posix environments, the encoding/decoding is fine. On Windows, I am seeing a conflict.

In pkg_deb, the solution is to write the description to a file, and have make_deb pull from that file.
But that is only one example. There are many other cases.
@aiuto aiuto added bug P2 An issue that should be worked on when time is available help wanted labels Aug 7, 2020
aiuto added a commit to aiuto/rules_pkg that referenced this issue Aug 7, 2020
@aiuto
disable unicode test cases on windows. See bazelbuild#214
e5e941f
aiuto added a commit that referenced this issue Aug 7, 2020
@aiuto
Convert pkg_deb tests from shell to python (#211)
933fa6f 
* Replace build_deb_test.sh with pkg_deb_test.py
* enable deb test on macos and windows
* remove third_party bashunit
* test needs hack on windows for  #213 and #214
@aiuto aiuto added P3 An issue that we are not working on but will review quarterly and removed P2 An issue that should be worked on when time is available labels Sep 24, 2020
aiuto added a commit to aiuto/rules_pkg that referenced this issue Nov 10, 2021
@aiuto
Buff the developer guide a bit.
4f3f53f 
Fixes bazelbuild#214.  More accurately, it moves the intent of bazelbuild#214 into
this guide. This feels appropriate because it is not a single problem,
but rather a general principal.
@aiuto aiuto mentioned this issue Nov 10, 2021
Merged
@aiuto aiuto closed this as completed in #470 Dec 7, 2021
aiuto added a commit that referenced this issue Dec 7, 2021
@aiuto
Buff the developer guide a bit. (#470)
1d24a6c 
* Buff the developer guide a bit.

Fixes #214.  More accurately, it moves the intent of #214 into
this guide. This feels appropriate because it is not a single problem,
but rather a general principal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted P3 An issue that we are not working on but will review quarterly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Buff the developer guide a bit. aiuto/rules_pkg
1 participant
@aiuto