fix(builtin): only stamp artifacts when --stamp is passed to bazel #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
approved these changes
Dec 10, 2019
docs/index.md
Outdated
|
|
||
| > Previous releases of rules_nodejs stamped builds always. | ||
| > However this caused stamp-aware actions to never be remotely cached, since the volatile | ||
| > status file is passed as an input and its checksum cannot be known. |
There was a problem hiding this comment.
nit: technically its that its checksum always changes
| @@ -129,6 +130,11 @@ NPM_PACKAGE_ATTRS = { | |||
| doc = """Files inside this directory which are simply copied into the package.""", | |||
| allow_files = True, | |||
| ), | |||
| "node_context_data": attr.label( | |||
There was a problem hiding this comment.
If this is internal should it be _ prefixed?
There was a problem hiding this comment.
in the rollup case, I override from a test. I guess I have no such test right now for npm_package doing the stamp thing but I like them being the same, and we ought to have such a test
There was a problem hiding this comment.
ah, the test for npm_package stamping was just busted. when I fixed the test it required passing this data to override --stamp. Fixed
Fixes remote cache misses of rollup_bundle and npm_package targets observed by Angular team
josephperrott
approved these changes
Dec 10, 2019
josephperrott
added a commit
to josephperrott/components
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
mmalerba
pushed a commit
to angular/components
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 16, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Dec 19, 2019
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remote cache misses of rollup_bundle and npm_package targets observed by Angular team