Skip to content

Commit

Permalink
build: update to [email protected] (#17929)
Browse files Browse the repository at this point in the history
Updating to latest rules_nodejs which properly handles stamping for
releases.  Previously rollup_bundle and npm_package were unable to
be cached remotely.
See bazel-contrib/rules_nodejs#1441 for changes.

With new requirements from changes in rules_nodejs, we now must add
--stamp to bazel builds we wish to include stamping.
  • Loading branch information
josephperrott authored and mmalerba committed Dec 11, 2019
1 parent 498b884 commit d3357b8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ test --test_output=errors
# Configures script to do version stamping.
# See https://docs.bazel.build/versions/master/user-manual.html#flag--workspace_status_command
build:release --workspace_status_command="node ./tools/bazel-stamp-vars.js"
build:release --stamp

################################
# View Engine / Ivy toggle #
Expand Down
4 changes: 2 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Add NodeJS rules
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = "8dc1466f8563f3aa4ac7ab7aa3c96651eb7764108219f40b2d1c918e1a81c601",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.41.0/rules_nodejs-0.41.0.tar.gz"],
sha256 = "a54b2511d6dae42c1f7cdaeb08144ee2808193a088004fc3b464a04583d5aa2e",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.42.3/rules_nodejs-0.42.3.tar.gz"],
)

# Add sass rules
Expand Down

0 comments on commit d3357b8

Please sign in to comment.