build: update to [email protected] #17929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to latest rules_nodejs which properly handles stamping for releases. Previously rollup_bundle and npm_package were unable to be cached remotely. See bazel-contrib/rules_nodejs#1441 for changes. With new requirements from changes in rules_nodejs, we now must add --stamp to bazel builds we wish to include stamping.
josephperrott
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
devversion
approved these changes
Dec 11, 2019
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to latest rules_nodejs which properly handles stamping for
releases. Previously rollup_bundle and npm_package were unable to
be cached remotely.
See bazel-contrib/rules_nodejs#1441 for changes.
With new requirements from changes in rules_nodejs, we now must add
--stamp to bazel builds we wish to include stamping.