Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated argument #118

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove deprecated argument #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tools/test_helpers.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def golden_cmd_test(
golden, # Required
toolchains = [],
tools = None,
exec_tools = None,
srcs = [], # Optional
**kwargs): # Rest
"""Compares cmd output to golden output, passes if they are identical.
Expand All @@ -56,7 +55,6 @@ def golden_cmd_test(
golden: The golden file to be compared.
toolchains: List of toolchains needed to run the command, passed to genrule.
tools: List of tools needed to run the command, passed to genrule.
exec_tools: List of tools needed to run the command, passed to genrule.
srcs: List of sources needed as input to the command, passed to genrule.
**kwargs: Any additional parameters for the generated golden_test.
"""
Expand All @@ -75,7 +73,6 @@ def golden_cmd_test(
cmd = cmd + " > '$@'", # Redirect to collect output
toolchains = toolchains,
tools = tools,
exec_tools = exec_tools,
testonly = True,
)

Expand Down