Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rules to declare licenses and their kinds should be in a distinct bazel package from the ones that consume them. #85

Open
aiuto opened this issue Mar 24, 2023 · 1 comment

Comments

@aiuto
Copy link
Collaborator

aiuto commented Mar 24, 2023

There are too many things in the rules package.
The expected use case is that everyone is going to by declaring a license rule, but fewer people will be using those to produce license audit or SBOMs. Most of the people who do produce an SBOM are expected to check rules_license into their repo and modify or reuse as appropriate, so having a clear separation between the packages you modify and the ones you leave alone is helpful.

@aiuto aiuto self-assigned this Mar 24, 2023
aiuto added a commit to aiuto/rules_license that referenced this issue Jun 3, 2023
…es_used.bzl

licenses_used is really an example of how the rules can work. As such it is really to be used for examples and as a reference implementation for people to build their own reports from.

This is part of the bazelbuild#85 cleanup.

Bonus: Fix the rule so it does not do a double write.
aiuto added a commit to aiuto/rules_license that referenced this issue Jun 3, 2023
- It does nothing that useful, and does not actually work yet.
- It relies on the older, get_licenses_info, API.

Part of bazelbuild#85
@aiuto aiuto added P2 and removed P1 labels Jun 22, 2023
@aiuto
Copy link
Collaborator Author

aiuto commented Jun 22, 2023

This is mostly done in 0.0.7. Not closed yet until we delete all the forwarders that were left behind.
That should be at 0.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant