chore: remove BUILD rules for building our release artifact

I'll send a follow-up PR to simply use 'git archive' to create it, along with GitHub Actions based release automation following Google security best-practice.
bazelbuild · Oct 29, 2023 · bb506a5 · bb506a5
1 parent 77bf7ab
commit bb506a5
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 86 deletions.
diff --git a/BUILD b/BUILD
@@ -48,17 +48,3 @@ exports_files(
     ]),
     visibility = ["//visibility:public"],
 )
-
-filegroup(
-    name = "standard_package",
-    srcs = glob([
-        "*.bzl",
-        "*.md",
-    ]) + [
-        "MODULE.bazel",
-        "BUILD",
-        "LICENSE",
-        "WORKSPACE.bzlmod",
-    ],
-    visibility = ["//distro:__pkg__"],
-)
diff --git a/distro/BUILD b/distro/BUILD
@@ -28,32 +28,6 @@ alias(
     actual = "rules_license-%s" % version,
 )
 
-# Build the artifact to put on the github release page.
-pkg_tar(
-    name = "rules_license-%s" % version,
-    srcs = [
-        ":small_workspace",
-        "//:standard_package",
-        "//licenses/generic:standard_package",
-        "//licenses/spdx:standard_package",
-        "//rules:standard_package",
-        "//rules_gathering:standard_package",
-        "//rules/private:standard_package",
-        "//sample_reports:standard_package",
-        "//tools:standard_package",
-    ],
-    extension = "tar.gz",
-    # It is all source code, so make it read-only.
-    mode = "0444",
-    # Make it owned by root so it does not have the uid of the CI robot.
-    owner = "0.0",
-    package_dir = ".",
-    strip_prefix = ".",
-    tags = [
-        "no_windows",
-    ],
-)
-
 genrule(
     name = "small_workspace",
     srcs = ["//:WORKSPACE"],

diff --git a/doc_build/BUILD b/doc_build/BUILD
@@ -26,17 +26,6 @@ load("//:version.bzl", "version")
 
 package(default_package_metadata = ["//:license", "//:package_info"])
 
-filegroup(
-    name = "standard_package",
-    srcs = [
-        "BUILD",
-    ] + glob([
-        "*.bzl",
-        "*.py",
-    ]),
-    visibility = ["//distro:__pkg__"],
-)
-
 exports_files(
     glob([
         "*.bzl",
@@ -91,8 +80,8 @@ bzl_library(
     name = "lib_of_everything",
     srcs = [
         "//:version.bzl",
-        "//rules:standard_package",
-        "//rules_gathering:standard_package",
+        "//rules:bzl",
+        "//rules_gathering:bzl",
     ],
     visibility = ["//visibility:public"],
 )

diff --git a/licenses/generic/BUILD b/licenses/generic/BUILD
@@ -44,11 +44,6 @@ package(
 
 licenses(["notice"])
 
-filegroup(
-    name = "standard_package",
-    srcs = ["BUILD"],
-)
-
 # "none" should be used for packages which are distributed with no license of
 # any kind. You can use this no-op license as a positive indication that the
 # code's license terms were reviewed, so that linters will not flag it later as

diff --git a/licenses/spdx/BUILD b/licenses/spdx/BUILD
@@ -61,11 +61,6 @@ package(
 
 licenses(["notice"])
 
-filegroup(
-    name = "standard_package",
-    srcs = ["BUILD"],
-)
-
 license_kind(
     name = "0BSD",
     conditions = [],

diff --git a/rules/BUILD b/rules/BUILD
@@ -33,12 +33,10 @@ trace(
     visibility = ["//visibility:public"],
 )
 
+# TODO(alexeagle): use gazelle to replace all these with bzl_library
 filegroup(
-    name = "standard_package",
-    srcs = glob([
-        "**/BUILD",
-        "**/*.bzl",
-    ]),
+    name = "bzl",
+    srcs = glob(["**/*.bzl"]),
 )
 
 # Do not create a bzl_library(). That would create a dependency loop back

diff --git a/rules/private/BUILD b/rules/private/BUILD
@@ -20,11 +20,6 @@ package(
 
 licenses(["notice"])
 
-filegroup(
-    name = "standard_package",
-    srcs = glob(["**"]),
-)
-
 # Do not create a bzl_library(). That would create a dependency loop back
 # to bazel-skylib. We export the .bzl files to the documentation maker.
 exports_files(

diff --git a/rules_gathering/BUILD b/rules_gathering/BUILD
@@ -18,9 +18,10 @@ package(
     default_visibility = ["//visibility:public"],
 )
 
+# TODO(alexeagle): use gazelle to replace all these with bzl_library
 filegroup(
-    name = "standard_package",
-    srcs = glob(["**"]),
+    name = "bzl",
+    srcs = glob(["*.bzl"]),
 )
 
 # Do not create a bzl_library(). That would create a dependency loop back

diff --git a/sample_reports/BUILD b/sample_reports/BUILD
@@ -22,11 +22,6 @@ package(
 
 licenses(["notice"])
 
-filegroup(
-    name = "standard_package",
-    srcs = glob(["**"]),
-)
-
 # Do not create a bzl_library(). That would create a dependency loop back
 # to bazel-skylib. We export the .bzl files to the documentation maker.
 exports_files(

diff --git a/tools/BUILD b/tools/BUILD
@@ -23,12 +23,6 @@ package(
 
 licenses(["notice"])
 
-filegroup(
-    name = "standard_package",
-    srcs = glob(["**"]),
-    visibility = ["//distro:__pkg__"],
-)
-
 exports_files(["diff_test.sh"])
 
 py_binary(