refactor go dependencies to a separate bzl file #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nlopezgi
commented
Jun 27, 2019
•
nlopezgi
commented
- Also update readme with instructions.
- Addresses Why does java_image rule needs to pull in golang rules? #935
- Will need to partially revert https://github.com/bazelbuild/bazel-toolchains/pull/593/files once this is in.
- Also reduced the timeout of the cloudbuild to create go puller binary from 6h to 1h
- Also extended timeout for run_instruction_arbitrary/cloudbuild.yaml to 20 minutes
nlopezgi
force-pushed
the
moveGoLoadToRepoBzl
branch
2 times, most recently
from
09afd20 to
c50519b
Compare
nlopezgi
force-pushed
the
moveGoLoadToRepoBzl
branch
from
c50519b to
431d0b6
Compare
nlopezgi
force-pushed
the
moveGoLoadToRepoBzl
branch
from
94141d6 to
1b64604
Compare
added 2 commits
June 27, 2019 00:05
…dbuild that has a value that is too high
|
We will need to release 0.8.1 after this PR is in |
smukherj1
reviewed
Jun 27, 2019
xingao267
reviewed
Jun 27, 2019
smukherj1
approved these changes
Jun 27, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.