add simple example that exersises minimal deps in WORKSPACE

README.md

@@ -120,16 +120,12 @@ docker_toolchain_configure(
   client_config="/path/to/docker/client/config",
 )
 
-# This is NOT needed when going through the language lang_image
-# "repositories" function(s).
 load(
     "@io_bazel_rules_docker//repositories:repositories.bzl",
     container_repositories = "repositories",
 )
 container_repositories()
 
-# This is NOT needed when going through the language lang_image
-# "repositories" function(s).
 load(
     "@io_bazel_rules_docker//repositories:go_repositories.bzl",
     container_go_deps = "go_deps",

cc/image.bzl

@@ -24,26 +24,13 @@ load(
     "//lang:image.bzl",
     "app_layer",
 )
-load(
-    "//repositories:go_repositories.bzl",
-    _go_deps = "go_deps",
-)
-load(
-    "//repositories:repositories.bzl",
-    _repositories = "repositories",
-)
 
 # Load the resolved digests.
 load(":cc.bzl", "DIGESTS")
 
 def repositories():
     """Import the dependencies for the cc_image rule.
-
-    Call the core "repositories" function to reduce boilerplate. This is
-    idempotent if folks call it themselves.
     """
-    _repositories()
-    _go_deps()
 
     excludes = native.existing_rules().keys()
     if "cc_image_base" not in excludes:

go/image.bzl

@@ -28,14 +28,6 @@ load(
     "//lang:image.bzl",
     "app_layer",
 )
-load(
-    "//repositories:go_repositories.bzl",
-    _go_deps = "go_deps",
-)
-load(
-    "//repositories:repositories.bzl",
-    _repositories = "repositories",
-)
 
 # Load the resolved digests.
 load(":go.bzl", "DIGESTS")
@@ -46,8 +38,6 @@ def repositories():
     Call the core "repositories" function to reduce boilerplate. This is
     idempotent if folks call it themselves.
     """
-    _repositories()
-    _go_deps()
 
     excludes = native.existing_rules().keys()
     if "go_image_base" not in excludes:

java/image.bzl

@@ -30,14 +30,6 @@ load(
     "layer_file_path",
     lang_image = "image",
 )
-load(
-    "//repositories:go_repositories.bzl",
-    _go_deps = "go_deps",
-)
-load(
-    "//repositories:repositories.bzl",
-    _repositories = "repositories",
-)
 
 # Load the resolved digests.
 load(
@@ -51,12 +43,7 @@ load(
 
 def repositories():
     """Import the dependencies of the java_image rule.
-
-    Call the core "repositories" function to reduce boilerplate. This is
-    idempotent if folks call it themselves.
     """
-    _repositories()
-    _go_deps()
 
     excludes = native.existing_rules().keys()
     if "java_image_base" not in excludes:

nodejs/image.bzl

@@ -27,26 +27,13 @@ load(
     "app_layer",
     lang_image = "image",
 )
-load(
-    "//repositories:go_repositories.bzl",
-    _go_deps = "go_deps",
-)
-load(
-    "//repositories:repositories.bzl",
-    _repositories = "repositories",
-)
 
 # Load the resolved digests.
 load(":nodejs.bzl", "DIGESTS")
 
 def repositories():
     """Import the dependencies of the nodejs_image rule.
-
-    Call the core "repositories" function to reduce boilerplate. This is
-    idempotent if folks call it themselves.
     """
-    _repositories()
-    _go_deps()
 
     excludes = native.existing_rules().keys()
     if "nodejs_image_base" not in excludes:

python/image.bzl

@@ -25,26 +25,13 @@ load(
     "app_layer",
     "filter_layer",
 )
-load(
-    "//repositories:go_repositories.bzl",
-    _go_deps = "go_deps",
-)
-load(
-    "//repositories:repositories.bzl",
-    _repositories = "repositories",
-)
 
 # Load the resolved digests.
 load(":python.bzl", "DIGESTS")
 
 def repositories():
     """Import the dependencies of the py_image rule.
-
-    Call the core "repositories" function to reduce boilerplate. This is
-    idempotent if folks call it themselves.
     """
-    _repositories()
-    _go_deps()
 
     # Register the default py_toolchain for containerized execution
     native.register_toolchains("@io_bazel_rules_docker//toolchains/python:container_py_toolchain")

python3/image.bzl

@@ -24,26 +24,13 @@ load(
     "//lang:image.bzl",
     "app_layer",
 )
-load(
-    "//repositories:go_repositories.bzl",
-    _go_deps = "go_deps",
-)
-load(
-    "//repositories:repositories.bzl",
-    _repositories = "repositories",
-)
 
 # Load the resolved digests.
 load(":python3.bzl", "DIGESTS")
 
 def repositories():
     """Import the dependencies of the py3_image rule.
-
-    Call the core "repositories" function to reduce boilerplate. This is
-    idempotent if folks call it themselves.
     """
-    _repositories()
-    _go_deps()
 
     # Register the default py_toolchain for containerized execution
     native.register_toolchains("@io_bazel_rules_docker//toolchains/python:container_py_toolchain")

testing/java_image/BUILD

@@ -0,0 +1,15 @@
+load("@io_bazel_rules_docker//java:image.bzl", "java_image")
+
+package(default_visibility = ["//visibility:public"])
+
+java_image(
+    name = "java_image",
+    srcs = [":Runfiles.java"],
+    data = [
+        ":foo",
+    ],
+    main_class = "examples.images.Runfiles",
+    deps = [
+        "@bazel_tools//tools/java/runfiles",
+    ],
+)

testing/java_image/Runfiles.java

@@ -0,0 +1,29 @@
+// Copyright 2017 The Bazel Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package examples.images;
+
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
+public class Runfiles {
+    public static void main(String[] args) throws IOException {
+	String path = com.google.devtools.build.runfiles.Runfiles.create()
+	    .rlocation("io_bazel_rules_docker/testdata/foo");
+	byte[] encoded = Files.readAllBytes(Paths.get(path));
+	System.out.println(new String(encoded, StandardCharsets.UTF_8));
+    }
+}

testing/java_image/WORKSPACE

@@ -0,0 +1,42 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+workspace(name = "java_image_example")
+
+local_repository(
+    name = "io_bazel_rules_docker",
+    path = "../../",
+)
+
+# Java language rules.
+load(
+    "@io_bazel_rules_docker//repositories:repositories.bzl",
+    container_repositories = "repositories",
+)
+
+container_repositories()
+
+load(
+    "@io_bazel_rules_docker//java:image.bzl",
+    _java_image_repos = "repositories",
+)
+
+_java_image_repos()
+
+load(
+    "@io_bazel_rules_docker//repositories:go_repositories.bzl",
+    container_go_deps = "go_deps",
+)
+
+container_go_deps()

testing/java_image/cloudbuild.yaml

@@ -0,0 +1,23 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Tests that verify the java_image eexample of rules_docker.
+# This basic test verifies dependencies can be resolved correctly for a
+# simple repo using java_image.
+
+steps:
+  # Test the java_app example.
+  - name: "l.gcr.io/google/bazel"
+    args: ["build", "//..."]
+    dir: "testing/java_image"

testing/java_image/foo

@@ -0,0 +1 @@
+asdf