Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel 8 compatibility (fork of #283) #284

Closed
wants to merge 18 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Upgrade rules_go
Currently relies on git_override and commit archive. Needs a rules_go
release containing bazel-contrib/rules_go#4182
to fully productionize.
ted-xie committed Dec 5, 2024
commit a090b4a7ebc963410a6293e81dad82b3636dcd14
5 changes: 5 additions & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
@@ -32,6 +32,11 @@ register_toolchains("//toolchains/android_sdk:all")

# go-related dependency setup
bazel_dep(name = "rules_go", version = "0.50.1", repo_name = "io_bazel_rules_go")
git_override(
module_name = "rules_go",
remote = "https://github.com/bazel-contrib/rules_go",
commit = "e8adba26a407fbea9354a6d88f6f97bf3ae1106c",
)
bazel_dep(name = "gazelle", version = "0.40.0", repo_name = "bazel_gazelle")
bazel_dep(name = "abseil-py", version = "2.1.0", repo_name = "py_absl")

6 changes: 3 additions & 3 deletions prereqs.bzl
Original file line number Diff line number Diff line change
@@ -84,10 +84,10 @@ def rules_android_prereqs(dev_mode = False):
maybe(
http_archive,
name = "io_bazel_rules_go",
sha256 = "f4a9314518ca6acfa16cc4ab43b0b8ce1e4ea64b81c38d8a3772883f153346b8",
sha256 = "4f404f8c1668764891feacc4cf222d82bf6da8461148f797d97843aa71043596",
strip_prefix = "rules_go-e8adba26a407fbea9354a6d88f6f97bf3ae1106c",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.50.1/rules_go-v0.50.1.zip",
"https://github.com/bazelbuild/rules_go/releases/download/v0.50.1/rules_go-v0.50.1.zip",
"https://github.com/bazel-contrib/rules_go/archive/e8adba26a407fbea9354a6d88f6f97bf3ae1106c.zip",
],
)