Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how Digest.hash is encoded generally. #285

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Clarify how Digest.hash is encoded generally. #285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb347f
Clarify how Digest.hash is encoded generally
tjgq Jan 15, 2024
2d8318e
Improve wording per review comments.
tjgq Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions build/bazel/remote/execution/v2/remote_execution.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,8 +981,7 @@ message SymlinkNode {
// serializing, but care should be taken to avoid shortcuts. For instance,
// concatenating two messages to merge them may produce duplicate fields.
message Digest {
// The hash. In the case of SHA-256, it will always be a lowercase hex string
// exactly 64 characters long.
// The hash, represented as a lowercase hex string including any leading zeroes.
tjgq marked this conversation as resolved.
Show resolved Hide resolved
string hash = 1;

// The size of the blob, in bytes.
Expand Down