Clarify how Digest.hash is encoded generally. #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems bad form to special-case SHA-256 while not saying anything about other digest functions. (I welcome corrections if my proposed correction does not correspond to actual usage in the wild.)
EdSchouten
reviewed
Jan 30, 2024
bergsieker
approved these changes
Feb 13, 2024
tjgq
changed the title
bergsieker
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems bad form to special-case SHA-256 while not saying anything about other digest functions. (I welcome corrections if my proposed wording does not correspond to actual usage in the wild.)